test(melange): incorrect path when public lib depends on private lib#7652
Merged
anmonteiro merged 1 commit intoocaml:mainfrom May 4, 2023
Merged
test(melange): incorrect path when public lib depends on private lib#7652anmonteiro merged 1 commit intoocaml:mainfrom
anmonteiro merged 1 commit intoocaml:mainfrom
Conversation
23dc067 to
33dae34
Compare
rgrinberg
approved these changes
Apr 27, 2023
jchavarri
approved these changes
Apr 28, 2023
rgrinberg
reviewed
Apr 28, 2023
| > EOF | ||
|
|
||
| $ dune build @melange --display=short | ||
| melc priv/.priv.objs/melange/priv.{cmi,cmj,cmt} |
Member
There was a problem hiding this comment.
Anything in particular that we need to see from this output?
Collaborator
Author
There was a problem hiding this comment.
I removed --display=short
33dae34 to
168bc21
Compare
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
168bc21 to
271f5fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node_modules) depends on a private library.I think this should be fine for installed libraries (I'll add a test too), but it's currently broken for libraries in the workspace.