test: (include_subdirs qualified) with (modules :standard \ baz)#7603
Closed
Alizter wants to merge 1 commit intoocaml:mainfrom
Closed
Conversation
Signed-off-by: Ali Caglayan <alizter@gmail.com>
c656fe3 to
912109d
Compare
Member
|
Test looks fine but it cannot be merged with the stack trace. You can try implementing the feature or filtering the stack trace. |
Collaborator
Author
|
@rgrinberg No harm in keeping it as draft until we fix it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repro case for #7597
Looks like:
dune/src/dune_rules/module_trie.ml
Lines 105 to 110 in 2a1c7e0
is unfinished.
cc @rgrinberg