Fix cinaps (link_flags) support version check#7446
Merged
nojb merged 3 commits intoocaml:mainfrom Mar 29, 2023
Merged
Conversation
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
rgrinberg
approved these changes
Mar 29, 2023
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
0454688 to
4a28b20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A mistake in #7423 meant that the new feature was versioned in terms of the version of the Dune language, instead of the version of the
cinapsextension. This PR fixes that.