bug: dune ocaml top-module crashes on absolute path#7369
Merged
rgrinberg merged 1 commit intoocaml:mainfrom Jul 23, 2023
Merged
Conversation
0634b6f to
8f8405b
Compare
937bce8 to
aa5c6ad
Compare
Collaborator
|
Can you open a PR for just the test first? |
aa5c6ad to
859cf31
Compare
Collaborator
Author
|
@emillon done. |
emillon
reviewed
Jul 18, 2023
Signed-off-by: Ali Caglayan <alizter@gmail.com>
0f04a21 to
83c3470
Compare
emillon
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro for #7370