Skip to content

test: show running dune build in subdir fails to find project root#7348

Closed
Alizter wants to merge 1 commit intoocaml:mainfrom
Alizter:ps/rr/test__show_running__dune_build__in_subdir_fails_to_find_project_root
Closed

test: show running dune build in subdir fails to find project root#7348
Alizter wants to merge 1 commit intoocaml:mainfrom
Alizter:ps/rr/test__show_running__dune_build__in_subdir_fails_to_find_project_root

Conversation

@Alizter
Copy link
Copy Markdown
Collaborator

@Alizter Alizter commented Mar 17, 2023

Running dune build in a subdirectory fails to find the project root. This is the underlying cause of #7344.

Signed-off-by: Ali Caglayan <alizter@gmail.com>

<!-- ps-id: 26722c1d-53ae-4a6f-8649-e36c5a8f8590 -->
@rgrinberg
Copy link
Copy Markdown
Member

root finding is disabled in tests because of INSIDE_DUNE

@Alizter
Copy link
Copy Markdown
Collaborator Author

Alizter commented Mar 17, 2023

Of course it is. I keep forgetting this.

@Alizter Alizter closed this Mar 17, 2023
@Alizter Alizter deleted the ps/rr/test__show_running__dune_build__in_subdir_fails_to_find_project_root branch March 17, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants