melange: add test to show flags passed from env#6656
Merged
rgrinberg merged 3 commits intoocaml:mainfrom Dec 12, 2022
Merged
Conversation
Signed-off-by: Javier Chávarri <javier.chavarri@gmail.com>
Member
|
I believe that it works, but how does this test verify that? How could I tell the flags are being passed? |
Signed-off-by: Javier Chavarri <javier.chavarri@gmail.com>
Signed-off-by: Javier Chavarri <javier.chavarri@gmail.com>
Collaborator
Author
Sorry, I am not sure what you mean. I refactored the test to proceed in 2 steps: first show the failing case, and then the fix using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6572. The PR just adds a test to demonstrate the functionality, but the implementation was added in #6569 inadvertently, as
Dune_envandDune_fileboth decode using the same function inOcaml_flags:dune/src/dune_rules/dune_env.ml
Line 191 in 1798cc6
dune/src/dune_rules/dune_file.ml
Line 172 in 1798cc6
Unless I'm missing something.