feature: enable (include_subdirs qualified)#6594
Merged
Conversation
8803c58 to
bede0ef
Compare
81b56de to
233a745
Compare
anmonteiro
reviewed
Nov 27, 2022
Collaborator
anmonteiro
left a comment
There was a problem hiding this comment.
did a very rough first pass, take all my suggestions as optional, as I'm trying to wrap my head around the implementation
2078ace to
4e09f53
Compare
7cfa498 to
12785e8
Compare
Member
Author
|
Okay, it's "alive". Nowhere near usable but the basic examples work. |
rgrinberg
commented
Nov 28, 2022
01be69c to
3414e23
Compare
anmonteiro
reviewed
Nov 29, 2022
c2733f6 to
676651c
Compare
01ef92e to
000e561
Compare
Collaborator
Merlin should be made aware of copy-rules and use them to determine source file location, but it remains to be done. The current behavior was introduced to reproduce how Merlin behaved before the dune-based configuration reader. I agree that it should eventually be replaced. |
voodoos
reviewed
Dec 5, 2022
5e30bf3 to
a8b837a
Compare
Member
Author
|
Alright, tests are passing. |
anmonteiro
reviewed
Dec 5, 2022
test/blackbox-tests/test-cases/merlin/merlin-from-subdir.t/run.t
Outdated
Show resolved
Hide resolved
anmonteiro
reviewed
Dec 5, 2022
anmonteiro
reviewed
Dec 5, 2022
a8b837a to
3e5885c
Compare
anmonteiro
approved these changes
Dec 5, 2022
b75caab to
40f8494
Compare
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: f0bdd789-87c5-4047-b418-47cdaf7749ae
40f8494 to
cbfa4f0
Compare
This was referenced Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(include_subdirs qualified)for OCaml libraries and executablesAliasing
We now build an alias module for every directory. To build a module
x/y/z.ml, we need to open-open X -open Y. Similarly, we can write an "interface module" for every directory:In this example,
Bar.Fooisn't accessible unless it's re-exported bybar.mlOcamldep Hacks
Currently ocamldep can't give us precise deps in situations such as:
ocamldep gives us
Bar, even though we really want to know that it'sLib__Bar__Bazthat we need. For now we just depend on everything in bar/. Hopefully codept will help us out here.TODO
Out of scope (for subsequent PR's):