Merged
Conversation
Alizter
commented
Nov 24, 2022
| | _ -> Coq_mode.VoOnly) | ||
| let+ config = Coq_config.make_opt ~coqc in | ||
| match config with | ||
| | None -> Coq_mode.VoOnly |
Collaborator
Author
There was a problem hiding this comment.
A case where we might not want this to happen is if we compose with the coq repo with native enabled and coqc --config doesn't work properly. Then this will silently not have the native rules. Perhaps a warning should be put here when this happens?
Before we were failing if for some reason `coqc --config` failed when selecting the native mode. This makes it so that if for whatever reason `coqc --config` doesn't succeed then we default to vo mode. Signed-off-by: Ali Caglayan <alizter@gmail.com> <!-- ps-id: b7e30052-8c48-411a-b2b1-32b3b60604f8 -->
0c1d5fb to
e9868cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we were failing if for some reason
coqc --configfailed when selecting the native mode. This makes it so that if for whatever reasoncoqc --configdoesn't succeed then we default to vo mode.Signed-off-by: Ali Caglayan alizter@gmail.com