Closed
Conversation
4855712 to
b87f6e2
Compare
Alizter
approved these changes
Oct 20, 2022
add a mechanism to allow the RPC server to initialized lazily Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: 4e972216-07ee-404e-9ab8-07b0e0a0ab1d
b87f6e2 to
cf7c047
Compare
Alizter
approved these changes
Oct 29, 2022
Member
Author
|
Replaced by #6360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a mechanism to allow the RPC server to initialized lazily. This is needed for the DAP to use dune rpc. When building something without watch mode (and hence without rpc), dynamic actions must first require the RPC server to be turned before proceeding with execution. This PR satisfies adds the API necessary to ensure this via
Rpc.ensure_ready