Include root and build context in dune describe#6092
Closed
zpyemont wants to merge 0 commit intoocaml:mainfrom
Closed
Include root and build context in dune describe#6092zpyemont wants to merge 0 commit intoocaml:mainfrom
zpyemont wants to merge 0 commit intoocaml:mainfrom
Conversation
debd3d4 to
1a8774a
Compare
Member
|
@esope are we ok with this? |
Collaborator
|
I think that having this extra info in the output of
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ROTOR we would like to have access to the original source files, not their locations within the build directory. To get this, we need the build context and the workspace root. This is an updated PR of #3834.
In this PR the build prefix and the path to the workspace root are added the the beginning of the output of
dune describe.