Skip to content

Added test for bad module names#5274

Closed
yannl35133 wants to merge 1 commit intoocaml:2.9from
yannl35133:bad-module-name
Closed

Added test for bad module names#5274
yannl35133 wants to merge 1 commit intoocaml:2.9from
yannl35133:bad-module-name

Conversation

@yannl35133
Copy link
Copy Markdown

No description provided.

@rgrinberg
Copy link
Copy Markdown
Member

Is there something missing from this test? It does not demonstrate a crash.

@rgrinberg
Copy link
Copy Markdown
Member

Feel free to re-open once you address my question.

@rgrinberg rgrinberg closed this Jan 13, 2022
@yannl35133
Copy link
Copy Markdown
Author

I imagine I didn't write the test correctly, if you have some time the steps to reproduce are simple and explained in the issue.
Also, the crash is apparent in the Checks tab, if that helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants