dune-site should replace paths in "sections", not "sites"#5192
dune-site should replace paths in "sections", not "sites"#5192bobot merged 3 commits intoocaml:mainfrom strub:fix-4389
Conversation
|
Great thank you! Do you think you can also add a test? |
|
Having it in dune |
|
In fact, the system is badly broken because of a bad interaction between the sites substitution and the version substitution. when the version is not needed or unavailable, the site substitution is totally ignored. I discovered this while writing the test. I am going to fix this first. |
|
Ok, I think I'm done with the fix & the test case. |
bobot
left a comment
There was a problem hiding this comment.
Thank you a lot. The branch is nearly good to go:
- Could you add a mention of the fix in Changes ?
- And (but I could do it if you don't have time) could you move the addition of the test before the fix, in order to see the improvement?
|
@bobot if you want this in 2.9.2 then please set the milestone and place the changes entry in the right place so we don't forget. |
|
@jeremiedimino Why in e16fca0 failure in reparsing the @strub I just modified your commits to update the tests so that the error is clear in the first commit. I will merge soon if you don't have any remark. Thanks a lot for the fix! |
|
@ejgallego the change is moved to 2.9.2 |
|
@bobot No remarks. You can merge! |
Great, thanks; will backport myself; if there is any problem I'll ping you guys. There is one other pending fix for 2.9.2 too, so I hope to release next week. |
Signed-off-by: Pierre-Yves Strub <pierre-yves@strub.nu>
Signed-off-by: François Bobot <francois.bobot@cea.fr>
- dune-site should replace paths in "sections", not "sites" - paths' substitution should be done in all cases (not only when a version is added to dune-package) fix #4389 Signed-off-by: Pierre-Yves Strub <pierre-yves@strub.nu>
|
@bobot I need help to create a 2.9 version of the changes in |
|
Ok , how do you want to proceed? |
|
We moved the discussion to slack. |
This should fix #4389