fix(cram): remove cram file after it is read#5042
Merged
Conversation
Member
Author
|
Hmm, this does not work quite as expected. It makes the diff fail unfortunately. We should run teh diff from outside the sandbox I suppose? |
00fbde0 to
0ceee79
Compare
Member
Author
|
@jeremiedimino I modified this to restore the test file if there's a diff. Seems to work fine. |
|
Cool |
ghost
reviewed
Nov 4, 2021
ghost
suggested changes
Nov 4, 2021
Tests shouldn't be able to observe the test files. However, we must restore the file if we observe a diff. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: 9962A972-82F0-4FB5-A8C9-D9B91083F09C
e02d1f3 to
678db88
Compare
Member
Author
|
Fixed #4777 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests shouldn't be able to observe the test files
Fix #4776