Remove the "ignore_for_watch" mechanism#5019
Closed
Conversation
This was an old mechanism to avoid restarting the build every time Dune promotes a file. It is no longer necessary now that we have Fs_cache. Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
snowleopard
approved these changes
Oct 19, 2021
Collaborator
snowleopard
left a comment
There was a problem hiding this comment.
Awesome! I assume you tested that it actually works as expected :)
Author
|
I should have :) It seems to work as expected, expect that the status line still changes to "Source file changed". Fixing that. |
Author
|
After more investigation: we can't remove this hack quite yet. The code that promotes the file tracks the source file via
As a result, if we remove this hack then we end up restarting the build everytime a file is promoted and its contents changes. With more work, we could still remove this hack and preserve the current behaviour. But this is a bigger change and not high priority, so let's keep the status quo for now. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an old mechanism to avoid restarting the build every time Dune promotes a file. It is no longer necessary now that we have
Fs_cache.