Merged
Conversation
There's no need to go through the Path based api Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Only create the symlink after the socket is created. This prevents clients from trying to connect through a dead link. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
There's now a sleep function in the Scheduler to make this easier Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
ad0f349 to
83ca2e1
Compare
Improve notification method in failed notifications Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are creating the symlink before the actual socket. Which means that it is possible for the client to observe a dead link. This PR changes the code to create the socket first.