Merged
Conversation
a77c5ba to
059d32a
Compare
Collaborator
Author
|
Fails as expected, as this also covers the bug #4749 fixes. |
This wasn't done in the past as to avoid the ugly grep, but the flag logic is delicate so we must start testing it properly. Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
059d32a to
e234743
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wasn't done in the past as to avoid the ugly grep, but the flag
logic is delicate so we must start testing it properly.