Closed
Conversation
Member
rgrinberg
commented
Jun 9, 2021
- stop reporting cancellation errors as normal errors
- report build interrupt/fail events
Introduce exceptions for fibers being cancelled and do not report those to RPC Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
aalekseyev
reviewed
Jun 9, 2021
| | Deterministic -> ()); | ||
| t.handler.error [ Add error ] | ||
| match exn.exn with | ||
| | Memo.Non_reproducible Scheduler.Run.Build_cancelled -> Fiber.return () |
Collaborator
There was a problem hiding this comment.
I don't think this should work because Memo drops the Memo.Non_reproducible wrapper when re-raising from what I remember.
Did you test this?
aalekseyev
reviewed
Jun 9, 2021
| ~handle_error_no_raise:(fun exn -> | ||
| Fiber.fork_and_join_unit | ||
| (fun () -> report_early_exn ~report_error exn) | ||
| (fun () -> |
Collaborator
There was a problem hiding this comment.
This looks like a weird place to report cancellation. First of all, the guarantee that some errors will be emitted after cancellation seems like a weird guarantee (it may be true now, but it seems more efficient and more reasonable to never emit events after cancellation).
Second, here you have to deal with duplicate events, and it's unclear why that's useful.
Why is the already-existing notification t.handler t.config Build_interrupted in let rec iter not sufficient?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.