Skip to content

Add dune-merlin-ppx_expect test#4478

Closed
jberdine wants to merge 4 commits intoocaml:mainfrom
jberdine:test
Closed

Add dune-merlin-ppx_expect test#4478
jberdine wants to merge 4 commits intoocaml:mainfrom
jberdine:test

Conversation

@jberdine
Copy link
Copy Markdown
Contributor

Test case for interop between dune and merlin when ppx_expect is used.

Signed-off-by: Josh Berdine <josh@berdine.net>
@voodoos
Copy link
Copy Markdown
Collaborator

voodoos commented Apr 12, 2021

Added a run.t file to activate the test.
It is failing because it needs Merlin master.

The illustrated issue is fixed in Merlin master and will be released soon.

@jberdine
Copy link
Copy Markdown
Contributor Author

The test output has timing stats in it, which makes this test, as an expect test, not useful. Is there an better way to do this that avoids time stats?

@voodoos
Copy link
Copy Markdown
Collaborator

voodoos commented Apr 14, 2021

You can filter-out Merlin's output with jq:
ocamlmerlin ....... | jq '.value'

And if we add that test to the suite we should add conf-jq to the test-deps in the Makefile.

@rgrinberg
Copy link
Copy Markdown
Member

Please re-open if this is still relevant

@rgrinberg rgrinberg closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants