Skip to content

Add failing test when cross-compiling with ppxs#4155

Merged
rgrinberg merged 1 commit intoocaml:mainfrom
TheLortex:ppx-cross-context-issue
Feb 9, 2021
Merged

Add failing test when cross-compiling with ppxs#4155
rgrinberg merged 1 commit intoocaml:mainfrom
TheLortex:ppx-cross-context-issue

Conversation

@TheLortex
Copy link
Copy Markdown
Collaborator

@TheLortex TheLortex commented Jan 25, 2021

Fails with:

File "lib/dune", line 3, characters 18-24:
3 |  (preprocess (pps fooppx)))
                      ^^^^^^
Error: Library "fooppx" in _build/cross-environment/ppx is hidden
(unsatisfied 'enabled_if').
-> required by lib/lib.pp.ml (context cross-environment)
-> required by alias lib/all (context cross-environment)
-> required by alias default (context cross-environment)
Hint: try:
  dune external-lib-deps --missing --debug-dependency-path @@default
[1]

@TheLortex TheLortex mentioned this pull request Jan 25, 2021
Open
@rgrinberg
Copy link
Copy Markdown
Member

rgrinberg commented Jan 26, 2021

Does this PR fix this issue? #3751

@TheLortex
Copy link
Copy Markdown
Collaborator Author

TheLortex commented Jan 26, 2021

Hey, unfortunately no it doesn't.
It looks like in dune_rules/preprocessing.ml, calls to Lib.DB.resolve_pps are made with the wrong scope (using the current scope instead of the host scope).

rgrinberg
rgrinberg reviewed Jan 26, 2021
View reviewed changes
test/blackbox-tests/test-cases/ppx-cross-context-issue.t/run.t
@@ -0,0 +1 @@
$ dune build --debug-dependency-path
Copy link
Copy Markdown
Member

@rgrinberg rgrinberg Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to promote?

This test also needs a description of the problem that it's trying to test.

Copy link
Copy Markdown
Collaborator Author

@TheLortex TheLortex Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promoted the error and added a description!

Add failing test when cross-compiling with ppxs
a2a1b21 
Signed-off-by: Lucas Pluvinage <lucas@tarides.com>
@TheLortex TheLortex force-pushed the ppx-cross-context-issue branch from 9e2341f to a2a1b21 Compare January 26, 2021 17:11
@rgrinberg rgrinberg merged commit 8330833 into ocaml:main Feb 9, 2021
@anmonteiro anmonteiro mentioned this pull request Mar 26, 2023
Merged
@dinosaure dinosaure mentioned this pull request Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgrinberg rgrinberg rgrinberg left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheLortex @rgrinberg