Merged
Conversation
snowleopard
approved these changes
Apr 22, 2020
Collaborator
snowleopard
left a comment
There was a problem hiding this comment.
Looks good but 2-3 sentences about the role of this module in the grand scheme of things would be very helpful. The current one-liner doesn't help me much.
This module was missing an mli for quite a while. The omission must have been accidental. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Member
Author
I've added a little more explanation. Truthfully, there's not much to explain as this module lives on its own to just break cycles. |
Collaborator
|
Thanks, I think the description you added is exactly what I was missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module was missing an mli for quite a while. The omission must have
been accidental.