[incremental cycles] Abstract vertex set type#3081
Closed
ejgallego wants to merge 2 commits intoocaml:masterfrom
Closed
[incremental cycles] Abstract vertex set type#3081ejgallego wants to merge 2 commits intoocaml:masterfrom
ejgallego wants to merge 2 commits intoocaml:masterfrom
Conversation
I used `Result.t` type, not sure this is the right choice. The implementation is a bit quite hackish for the `Map` case, maybe it should be upstreamed into OCaml; suggestions welcome. Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
cf5aca7 to
c0fe8cc
Compare
This way clients can provide their own iterator. Signed-off-by: Emilio Jesus Gallego Arias <e+git@x80.org>
c0fe8cc to
3aa99f7
Compare
Collaborator
Author
|
I'm going to close this for now; given that the solution in #2959 doesn't finally need a change of API. If upstream wants to tweak the API more we can just indeed follow up in their repos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After discussion in #2959 , we abstract the vertex set representation in incremental cycles.
cc: @Armael