Switch the whole code base to the new error reporting API#2349
Merged
1 commit merged intomasterfrom Jul 3, 2019
unknown repository
Merged
Switch the whole code base to the new error reporting API#23491 commit merged intomasterfrom unknown repository
1 commit merged intomasterfrom
unknown repository
Conversation
Collaborator
|
I think that the output could be made even better, for example by using hanging indent or putting "error:" on its own line when it wraps, but this will be made possible by switching to the new API. Thanks! |
Author
|
Indeed, now that we have a robust and uniform way of reporting well formatted errors such changes should be much easier to do :) |
Signed-off-by: Jeremie Dimino <jeremie@dimino.org>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last PR to switch the code base to the new error reporting API. It convert all errors and warnings to the new API. As can be seen in the test suite, the formatting of a lot of error message is improved and the
Error:prefix is added in many places where it was previously missing.This diff is huge, however most of the changes are pretty mechanical. And since the majority of error messages are tested, it doesn't seem necessary to review the whole diff in detail. I suggest to simply read the diff of the
test/directory to review this PR.Apart from the conversion of all errors, this PR also contains the following additional changes:
Errorsmodule which was almost empty after these changes. I movedAlready_reportedtoReport_errorand mergedErrors.printintoLoc.printppfunctions inDune_langin aDeprecatedsub-module in order to introduce a newppfunction returning a_ Pp.tvalue