Skip to content

Specifies the object directory in module#1709

Merged
rgrinberg merged 2 commits intomasterfrom
add_obj_dir_in_modules
Dec 26, 2018
Merged

Specifies the object directory in module#1709
rgrinberg merged 2 commits intomasterfrom
add_obj_dir_in_modules

Conversation

@bobot
Copy link
Copy Markdown
Collaborator

@bobot bobot commented Dec 22, 2018

Big refactorisation that push the object directory inside Module.t

  • Adds Module.Source.t for module source not yet with object so with obj_dir
  • Remove the need to thread the obj_dir everywhere
  • Requires to convert the virtual modules to the implementation module
  • Require to convert local module to the installed module
  • utop target has now the same layout than other executables
  • the serialization of Module.t is relative to main library directory

@bobot bobot requested review from a user and rgrinberg December 22, 2018 14:46
@bobot bobot force-pushed the add_obj_dir_in_modules branch 2 times, most recently from 9aeb141 to dce473d Compare December 22, 2018 14:51
rgrinberg
rgrinberg requested changes Dec 22, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. I'm really looking forward to this change to attempt to get rid of all the copying for virtual module implementations. But to do that, I think I will need a Obj_dir.t per impl/intf. Do you have any comments or suggestions on how I should do that?

@bobot bobot force-pushed the add_obj_dir_in_modules branch from a85e9e0 to d594a49 Compare December 22, 2018 19:23
@bobot
Copy link
Copy Markdown
Collaborator Author

bobot commented Dec 22, 2018

But to do that, I think I will need a Obj_dir.t per impl/intf.

I think we should have an easier way to compute the -I, currently the logic is separated from the information contained in Module.t. After that I think we should look that again after the new layout and alternative_interfaces is done.

@bobot bobot mentioned this pull request Dec 23, 2018
Merged
@bobot
Specifies the object directory in module
cd213cd 
  - Adds Module.Source.t for module yet without object
  - Remove the need to thread the obj_dir everywhere
  - Requires to convert the virtual modules to the implementation module

Signed-off-by: François Bobot <francois.bobot@cea.fr>
@bobot bobot force-pushed the add_obj_dir_in_modules branch from d594a49 to cd213cd Compare December 24, 2018 16:32
@rgrinberg rgrinberg merged commit 528ed3a into master Dec 26, 2018
@rgrinberg rgrinberg deleted the add_obj_dir_in_modules branch December 26, 2018 17:56
@rgrinberg
Copy link
Copy Markdown
Member

rgrinberg commented Dec 26, 2018

Merged as I need this for other work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgrinberg rgrinberg rgrinberg approved these changes

@emillon emillon Awaiting requested review from emillon

@fpottier fpottier Awaiting requested review from fpottier

@trefis trefis Awaiting requested review from trefis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobot @rgrinberg