Closed
Conversation
Signed-off-by: François Bobot <francois.bobot@cea.fr>
Signed-off-by: François Bobot <francois.bobot@cea.fr>
Member
|
@emillon mind reviewing this? |
Collaborator
|
Sure! But it probably won't be before tomorrow. |
Member
|
I ended up having time today after all. Code looks very good and is one of the few cases where the operators increased the readability. I merged this with a few tweaks to the error messages and decluttering find_errors by hoisting up all the helper functions to |
Collaborator
|
OK! I'm not convinced by the operators by I'm willing to try :) |
Collaborator
Author
|
Thanks! Is there a drawback for you to force push your modification then merge? I think it helps external people know which features are merged. |
Member
|
There's no drawback. I will force push and just merge via github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reformulate the checks so that they are easier to check.