Skip to content

Simplify the --force tests#1459

Merged
rgrinberg merged 1 commit intoocaml:masterfrom
rgrinberg:remove-extra-display-force
Oct 15, 2018
Merged

Simplify the --force tests#1459
rgrinberg merged 1 commit intoocaml:masterfrom
rgrinberg:remove-extra-display-force

Conversation

@rgrinberg
Copy link
Copy Markdown
Member

@rgrinberg rgrinberg commented Oct 15, 2018

There's no need to clean in the beginning or rely on --display short to check if
something is rebuilt

@ejgallego could you check if this fixes the force-test test for you? You can run it individually with $ dune build @force-test btw.

@rgrinberg
Simplify the --force tests
c7b0b86 
There's no need to clean in the beginning or rely on --display short to check if
something is rebuilt

Signed-off-by: Rudi Grinberg <rudi.grinberg@gmail.com>
@rgrinberg rgrinberg requested a review from a user October 15, 2018 16:02
@rgrinberg rgrinberg requested a review from emillon as a code owner October 15, 2018 16:02
@ejgallego ejgallego mentioned this pull request Oct 15, 2018
Closed
@rgrinberg rgrinberg merged commit e28a54b into ocaml:master Oct 15, 2018
@rgrinberg rgrinberg deleted the remove-extra-display-force branch October 15, 2018 16:44
@ejgallego
Copy link
Copy Markdown
Collaborator

ejgallego commented Oct 15, 2018

@ejgallego could you check if this fixes the force-test test for you? You can run it individually with $ dune build @force-test btw.

This fixes the force test, thanks. But note about the target you suggest:

egallego@kaguya:~/external/dune$ dune build @force-test
File "bin/dune", line 8, characters 14-23:
8 |  (name        main_dune)
                  ^^^^^^^^^
Error: No rule found for src/which_program/which_program.a
File "bin/dune", line 16, characters 14-27:
16 |  (name        main_jbuilder)
                   ^^^^^^^^^^^^^
Error: No rule found for src/which_program/which_program.a
File "test/blackbox-tests/dune", line 4, characters 7-11:
4 |  (name cram)
           ^^^^
Error: No rule found for src/which_program/which_program.a

@rgrinberg
Copy link
Copy Markdown
Member Author

rgrinberg commented Oct 15, 2018

This fixes the force test, thanks. But note about the target you suggest:

Hmm, I'm unable to reproduce. It's quite strange that it's looking for the archive in that location however. Since which_program is a virtual library, those archives should exist in the concrete implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emillon emillon Awaiting requested review from emillon

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rgrinberg @ejgallego