fix(memo): check for self-dependency cycles before blocking on ivar#13710
Merged
anmonteiro merged 1 commit intoocaml:mainfrom Mar 3, 2026
Merged
fix(memo): check for self-dependency cycles before blocking on ivar#13710anmonteiro merged 1 commit intoocaml:mainfrom
anmonteiro merged 1 commit intoocaml:mainfrom
Conversation
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Collaborator
|
Does this resolve the original deadlock in #5771? |
Collaborator
Author
Collaborator
|
@anmonteiro I think its fine not to include it, I just wanted to have a record of the fact that it did in fact fix the original issue. The other reproduction case is better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5771