Skip to content

ci: reenable rocq#13529

Merged
Alizter merged 6 commits intoocaml:mainfrom
Alizter:fix-rocq-ci
Feb 6, 2026
Merged

ci: reenable rocq#13529
Alizter merged 6 commits intoocaml:mainfrom
Alizter:fix-rocq-ci

Conversation

@Alizter
Copy link
Copy Markdown
Collaborator

@Alizter Alizter commented Feb 2, 2026

In this PR we:

  • add rocq to the nix flake
  • fixup the output of all the rocq tests
  • fixup the output of all the rocq-native tests
  • re-enable the Rocq CI for both normal and native
  • remove coq from the nix flake and the ci

@Alizter
Copy link
Copy Markdown
Collaborator Author

Alizter commented Feb 2, 2026

@rlepigre-skylabs-ai could you have a look through the tests and make sure they still make sense. I've also fixed an issue where we were calling rocq --config which doesn't exist and we should have been calling rocq compile --config instead.

@rlepigre-skylabs-ai
Copy link
Copy Markdown
Collaborator

@rlepigre-skylabs-ai could you have a look through the tests and make sure they still make sense. I've also fixed an issue where we were calling rocq --config which doesn't exist and we should have been calling rocq compile --config instead.

Sure, I'll have a look.

By the way, I'm pretty sure that rocq --config does exist (with the same output as rocq compile --config). What made you think it didn't?

Copy link
Copy Markdown
Collaborator

@rlepigre-skylabs-ai rlepigre-skylabs-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable as far as I can tell.

@Alizter
Copy link
Copy Markdown
Collaborator Author

Alizter commented Feb 2, 2026

@rlepigre-skylabs-ai is rocq --config coming from a comparability shim or something? The nix flake I have does not have that option.

@Alizter Alizter added the rocq label Feb 2, 2026
@Alizter
Copy link
Copy Markdown
Collaborator Author

Alizter commented Feb 2, 2026

Ah, I think the issue was rocq --config doesn't work for 9.0, which I had tried initially, however does work for 9.1.

@rlepigre-skylabs-ai
Copy link
Copy Markdown
Collaborator

Ah, I think the issue was rocq --config doesn't work for 9.0, which I had tried initially, however does work for 9.1.

Ah, that would make sense. In that case is it better to keep using rocq compile --config?

@Alizter Alizter force-pushed the fix-rocq-ci branch 2 times, most recently from 60c1918 to 819740b Compare February 2, 2026 23:34
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>

update rcoq config tests

Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
The tests are disabled anyway

Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter
Copy link
Copy Markdown
Collaborator Author

Alizter commented Feb 5, 2026

@rlepigre-skylabs-ai I've removed the changes about rocq compile --config and will submit that as a follow up.

@Alizter Alizter marked this pull request as ready for review February 5, 2026 10:22
@Alizter Alizter requested a review from rgrinberg February 6, 2026 11:20
@Alizter Alizter merged commit 270e12c into ocaml:main Feb 6, 2026
29 checks passed
@Alizter Alizter deleted the fix-rocq-ci branch February 6, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants