refactor: add fire_notification to rpc_common and use in shutdown#12675
Merged
Alizter merged 1 commit intoocaml:mainfrom Nov 5, 2025
Merged
refactor: add fire_notification to rpc_common and use in shutdown#12675Alizter merged 1 commit intoocaml:mainfrom
Alizter merged 1 commit intoocaml:mainfrom
Conversation
3ff7840 to
7e9b94d
Compare
7e9b94d to
579d34c
Compare
Alizter
approved these changes
Nov 5, 2025
Collaborator
Alizter
left a comment
There was a problem hiding this comment.
I agree in principle that commands should be interfacing with RPC using a high level API like we have in rpc_common. I would like that to have less surface area however, but that's a future improvement.
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
579d34c to
c236cb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split-off from #12580