Remove duplicate code in diagnostics#12674
Merged
Alizter merged 1 commit intoocaml:mainfrom Nov 4, 2025
Merged
Conversation
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
86cff98 to
a8e7958
Compare
shonfeder
approved these changes
Nov 4, 2025
Member
shonfeder
left a comment
There was a problem hiding this comment.
It's not clear from this diff how this is removing "duplicate code", but I assume that context would be revealed by comparing against the other diffs, and the change looks simple and clean. Thanks for the small PR!
Alizter
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split-off from #12580