Add DUNE_ROOT environment variable#12438
Merged
Alizter merged 2 commits intoocaml:mainfrom Sep 10, 2025
Merged
Conversation
Collaborator
|
Thanks for the contribution! Can you sign off your commit and add a cram test to show that |
f08d92f to
cbb3ee3
Compare
Contributor
Author
|
@Leonidas-from-XIV done, please review 🙏 |
Collaborator
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Thanks. The test is quite nice, covers a good chunk of functionality. I've added a few comments how to make it nicer.
Please also add a changelog entry in doc/changes/12438.md. It would probably also be good to mention the new variable in the documentation, e.g. somewhere here where --root is documented: https://dune.readthedocs.io/en/stable/usage.html#finding-the-root
Contributor
Author
|
All suggestions have been addressed in abe5286, please review again 🙏 |
Leonidas-from-XIV
approved these changes
Sep 10, 2025
Collaborator
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution!
abe5286 to
332f46d
Compare
Closes ocaml#12399 Signed-off-by: Julien Debon <julien.debon@routine.co>
Signed-off-by: Julien Debon <julien.debon@routine.co>
332f46d to
6f70aea
Compare
Alizter
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12399