Merged
Conversation
Alizter
reviewed
Aug 20, 2025
ddbd9c9 to
5531fdb
Compare
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 9ca251a5-a46a-4d92-ac0e-aa616cee014d --> Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
5531fdb to
c0f1e09
Compare
Member
Author
|
Alright, this works well now. The obvious candidate to use this would be in the dune executable stanza itself. Unfortunately, due to another limitation in the bootstrapping process, this cannot be done at the moment. One step at a time. This change requires bootstrap to be re-done again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the root_module in bootstrap
This allows us to write proper wrapper modules like I've done for Pp in this PR.