Skip to content

chore: add x-maintenance-intent to dune opam files#11275

Closed
art-w wants to merge 2 commits intoocaml:mainfrom
art-w:maintenance-intent-latest
Closed

chore: add x-maintenance-intent to dune opam files#11275
art-w wants to merge 2 commits intoocaml:mainfrom
art-w:maintenance-intent-latest

Conversation

@art-w
Copy link
Copy Markdown
Collaborator

@art-w art-w commented Jan 7, 2025

Using #11274 to add it to every opam files. My understanding is that only the "(latest)" version is the one actively maintained, but it's easy to change if you want to include more versions.

@art-w art-w mentioned this pull request Jan 7, 2025
Merged
@art-w art-w marked this pull request as draft January 7, 2025 14:11
@Leonidas-from-XIV
Copy link
Copy Markdown
Collaborator

Leonidas-from-XIV commented Jan 10, 2025

The OPAM files are generated automatically from dune-project so unless the change is added in the respective .template files, the change will be removed on the next dune build. I suggest landing #11274 first and then adding maintenance_intent to our dune-project in this PR, which will automatically update the opam files.

@art-w art-w force-pushed the maintenance-intent-latest branch from 98c9a89 to c1a0148 Compare January 15, 2025 15:01
@maiste maiste force-pushed the maintenance-intent-latest branch from c1a0148 to c1c53bc Compare January 21, 2025 13:15
Leonidas-from-XIV
Leonidas-from-XIV requested changes Jan 21, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of these changes need to be discussed because while we do release them as packages I don't think all of them are meant to be used by others.

e.g. I don't think that we would do a patch-release for a bug in stdune if it doesn't affect the dune package. We'd probably fix it upstream to prevent it becoming an issue in the future but a lot of these packages are really just to support Dune.

@maiste maiste force-pushed the maintenance-intent-latest branch 2 times, most recently from 002b084 to 4a5b03b Compare January 23, 2025 14:04
@Leonidas-from-XIV
Copy link
Copy Markdown
Collaborator

Leonidas-from-XIV commented Jan 23, 2025

@rgrinberg Can you take a look and confirm that this matches our maintenance policy?

@maiste maiste force-pushed the maintenance-intent-latest branch from 4a5b03b to 4b63540 Compare January 23, 2025 14:05
@maiste maiste marked this pull request as ready for review January 23, 2025 14:05
@maiste maiste changed the title Add x-maintenance-intent to dune opam files chore: add x-maintenance-intent to dune opam files Jan 23, 2025
@maiste
Copy link
Copy Markdown
Collaborator

maiste commented Jan 23, 2025

I encounter an issue while working on this PR. To be able to have the maintenance field in dune-project, I need to increase the number of the lang to 3.18. If I do so, it will build the maintenance field, but it will complain that it can't install dune >= 3.18 because this version does not exist in the local switch test.

Also, it seems that the 3.18 version is the one that changed the formatting, so it also requires the formatting to change. Should it be done in a separated PR if possible?

@Leonidas-from-XIV
Copy link
Copy Markdown
Collaborator

Leonidas-from-XIV commented Jan 23, 2025

With regards to the switch test, the issue seems to be that the packages are getting pinned to 3.17.1 instead of 3.18:

xdg is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
stdune is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
ordering is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
ocamlc-loc is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
dyn is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
dune is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
dune-site is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
dune-rpc is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
dune-rpc-lwt is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
dune-private-libs is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
dune-glob is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
dune-configurator is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
dune-build-info is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
dune-action-plugin is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)
chrome-trace is now pinned to git+file:///home/runner/work/dune/dune#HEAD (version 3.17.1)

But I do agree that this PR probably needs to be split into two, one that bumps to 3.17 and adds the formatting and one that bumps to 3.18 and updates the maintenance intent.

@maiste
Copy link
Copy Markdown
Collaborator

maiste commented Jan 23, 2025

You are right, let's do it this way 👍

@maiste maiste added the chore Something that just needs to be done. label Jan 27, 2025
@rgrinberg rgrinberg force-pushed the maintenance-intent-latest branch from 4b63540 to 523cdaf Compare February 7, 2025 22:53
@maiste maiste mentioned this pull request Feb 11, 2025
Merged
art-w and others added 2 commits February 18, 2025 11:44
@art-w
Add x-maintenance-intent to dune opam files
85027ee 
Signed-off-by: ArthurW <arthur@tarides.com>
Signed-off-by: Etienne Marais <dev@maiste.fr>
@maiste @art-w
chore: x-maintenance-intent none
1fb1ec1 
Signed-off-by: Etienne Marais <dev@maiste.fr>
@art-w art-w force-pushed the maintenance-intent-latest branch from 523cdaf to 1fb1ec1 Compare February 18, 2025 10:45
Leonidas-from-XIV
Leonidas-from-XIV approved these changes Feb 18, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good but for now blocked on #11478 as it is experiencing the same CI failures for the same reason.

@maiste
Copy link
Copy Markdown
Collaborator

maiste commented May 5, 2025

Because #11478 superseeds this PR, we can close it.

@maiste maiste closed this May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leonidas-from-XIV Leonidas-from-XIV Leonidas-from-XIV approved these changes

@rgrinberg rgrinberg rgrinberg approved these changes

Assignees

No one assigned

Labels

chore Something that just needs to be done.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@art-w @Leonidas-from-XIV @maiste @rgrinberg