Conversation
Signed-off-by: Jérôme Vouillon <jerome.vouillon@gmail.com>
Signed-off-by: Jérôme Vouillon <jerome.vouillon@gmail.com>
Signed-off-by: Jérôme Vouillon <jerome.vouillon@gmail.com>
Signed-off-by: Jérôme Vouillon <jerome.vouillon@gmail.com>
Signed-off-by: Jérôme Vouillon <jerome.vouillon@gmail.com>
|
@rgrinberg The CI should pass now (I have updated wasm_of_ocaml to accept the Without modifying any dune files, I would like the flexibility to either:
This could potentially be managed through a profile, and also possibly by detecting whether wasm_of_ocaml is installed. However, I'm unsure how to achieve this using dune's regular modes, which seem fairly static. Do you have any suggestions? Currently, we use different profiles to determine whether to run the js_of_ocaml test suite with js_of_ocaml or wasm_of_ocaml. Given that programs built with wasm_of_ocaml don’t work everywhere (e.g., Safari doesn’t yet support Wasm GC), and considering that wasm_of_ocaml introduces additional dependencies (it requires the installation of Binaryen), it seems important to me to offer flexibility to the end user. |
|
Did you push or release your changes? I still see: |
|
This can be closed |
So far it's failing: