Closed
Conversation
Signed-off-by: Masayuki Takeda <mtakeda@oeconomia.jp>
1f7d922 to
94e28ad
Compare
anmonteiro
approved these changes
May 26, 2024
rgrinberg
approved these changes
May 26, 2024
Member
rgrinberg
left a comment
There was a problem hiding this comment.
@anmonteiro feel free to merge if you understand the issue. I added some comments about missing dependencies though
| (targets libtest.a dlltest.so) | ||
| (action | ||
| (progn | ||
| (run gcc -c -fPIC test.c -o test.o) |
Member
There was a problem hiding this comment.
The test should depend on the gcc binary and ar binaries.
Collaborator
|
Continued in #10586 because this test fails on macOS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction of #10582.