add reproduction test for #10236#10241
Merged
gridbugs merged 1 commit intoocaml:mainfrom Mar 14, 2024
Merged
Conversation
Member
|
@gridbugs could you have a look at this one? |
Collaborator
|
Happy for this to be merged. I've got a PR open which fixes this issue (#10262) which I will merge after the current PR is merged. |
Signed-off-by: Corentin Leruth <corentin.leruth@gmail.com>
23131a7 to
e991d2d
Compare
Contributor
Author
|
Thanks for the fix @gridbugs 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a reproduction test for #10236. Unfortunately, watch tests are disabled due to some issues on CI (+macos)
dune/test/blackbox-tests/test-cases/exec-watch/dune
Lines 1 to 15 in c41993f
Perhaps this one would cause less problems as we don't actually need to watch anything? In any case, I hope this will help to fix the problem.