Skip to content

feat(boot): specify platform-specific cflags#10217

Closed
emillon wants to merge 1 commit intoocaml:mainfrom
emillon:boot-build-libs
Closed

feat(boot): specify platform-specific cflags#10217
emillon wants to merge 1 commit intoocaml:mainfrom
emillon:boot-build-libs

Conversation

@emillon
Copy link
Copy Markdown
Collaborator

@emillon emillon commented Mar 5, 2024

These flags have the same semantics as link_flags but are used when building C code.

These flags have the same semantics as `link_flags` but are used when
building C code.

Signed-off-by: Etienne Millon <me@emillon.org>
@rgrinberg
Copy link
Copy Markdown
Member

Why do we need this feature?

@emillon
Copy link
Copy Markdown
Collaborator Author

emillon commented Mar 6, 2024

The context is #10212, we can take the discussion there.

@rgrinberg
Copy link
Copy Markdown
Member

Okay, so this PR isn't useful on its own and the feature cannot even be exercises in it. I'd say just submit it as a part of #10212 then

@rgrinberg
Copy link
Copy Markdown
Member

Closing as it's not a refactoring and as a feature, it's not usable on its own.

@rgrinberg rgrinberg closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants