Merged
Conversation
* fix(engine): remove old target even if it is a dir Fixes ocaml#6575 Signed-off-by: Etienne Millon <me@emillon.org> * Add changelog entry Signed-off-by: Etienne Millon <me@emillon.org> * Ignore EPERM on darwin Signed-off-by: Etienne Millon <me@emillon.org> * Extract Fpath.unlink_status Signed-off-by: Etienne Millon <me@emillon.org> * Change file to directory Signed-off-by: Etienne Millon <me@emillon.org> * Keep exceptions Signed-off-by: Etienne Millon <me@emillon.org> * Use a single constructor for exn Signed-off-by: Etienne Millon <me@emillon.org> * Log error Signed-off-by: Etienne Millon <me@emillon.org> * rename Fpath.unlink to Fpath.unlink_exn Signed-off-by: Etienne Millon <me@emillon.org> * rename Path.unlink to Path.unlink_exn Signed-off-by: Etienne Millon <me@emillon.org> * rename Fpath.unlink_status to Fpath.unlink Signed-off-by: Etienne Millon <me@emillon.org> * rename Path.unlink_status to Path.unlink Signed-off-by: Etienne Millon <me@emillon.org> * do not log error if file does not exist Signed-off-by: Etienne Millon <me@emillon.org> --------- Signed-off-by: Etienne Millon <me@emillon.org>
15 tasks
emillon
approved these changes
Mar 5, 2024
Collaborator
emillon
left a comment
There was a problem hiding this comment.
👍🏻 , make sure to update the PR description to remove the draft part and the Fixes:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9327 to 3.14.