-
Notifications
You must be signed in to change notification settings - Fork 470
Why is patdiff instructed to show unrefined diffs? #4254
Copy link
Copy link
Closed
Description
Desired Behavior
When it's installed, Dune uses the patdiff utility to show diffs as part of, for example, expectation tests.
My understanding is that the value proposition of patdiff is that it shows more refined diffs than whole-line changes.
For example, a diff produced by patdiff could identify clearly a single integer being different on a line that's otherwise the same.
Current behavior
While there's an explicit check for patdiff being present here, the -unrefined flag is being passed to patdiff, which is counter-intuitive to me.
Is the reason for this performance? If so, I'd personally prefer that the default was to omit -unrefined and to make its inclusion an option exposed somehow in Dune.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels