-
Notifications
You must be signed in to change notification settings - Fork 470
runtest_alias no longer working properly #12243
Copy link
Copy link
Closed
ocaml/opam-repository
#28397Description
Expected Behavior
Suppose I have the following dune file:
(env
(_
(js_of_ocaml
(runtest_alias runtest-js))))
(test (name foo) (modes byte js))
When running dune build @runtest-js, the test should only be executed in js mode.
Actual Behavior
With Dune 3.20, the test in run both in byte and js mode.
The issue was introduce in #11558: instead of being an alias for the relevant rule, runtest-js is now an alias for runtest-foo.
dune/src/dune_rules/test_rules.ml
Lines 132 to 134 in 8c0994b
| >>> (Dep.alias alias | |
| |> Action_builder.dep | |
| |> Rules.Produce.Alias.add_deps runtest_alias) |
Reproduction
- PR with a reproducing test: test: make sure runtest_alias works properly #12242
Specifications
- Version of
dune: 3.20.0
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels