Skip to content

runtest_alias no longer working properly #12243

@vouillon

Description

@vouillon

Expected Behavior

Suppose I have the following dune file:

(env
 (_
  (js_of_ocaml
   (runtest_alias runtest-js))))

(test (name foo) (modes byte js))

When running dune build @runtest-js, the test should only be executed in js mode.

Actual Behavior

With Dune 3.20, the test in run both in byte and js mode.

The issue was introduce in #11558: instead of being an alias for the relevant rule, runtest-js is now an alias for runtest-foo.

>>> (Dep.alias alias
|> Action_builder.dep
|> Rules.Produce.Alias.add_deps runtest_alias)

Reproduction

Specifications

  • Version of dune: 3.20.0

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions