Skip to content

JS#6

Merged
obuisard merged 1 commit intoobuisard:4.3-devfrom
dgrammatiko:4.3-dev-g-t
Feb 23, 2023
Merged

JS#6
obuisard merged 1 commit intoobuisard:4.3-devfrom
dgrammatiko:4.3-dev-g-t

Conversation

@dgrammatiko
Copy link
Copy Markdown

Pull Request for Issue # .

Summary of Changes

  • Use modern JS
  • DO NOT ship Shepard in the vendor (we have imports for that) this frees the project from the can't upgrade to major version of x dependency on a minor/patch version of Joomla
Screen.Recording.2023-02-21.at.14.28.39.mp4

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

- DO NOT expose shepherd in the vendor
@obuisard obuisard merged commit 9b986c1 into obuisard:4.3-dev Feb 23, 2023
@obuisard
Copy link
Copy Markdown
Owner

Thank you Dimitris, these were great suggestions and changes. I appreciate the help :-)

@dgrammatiko dgrammatiko deleted the 4.3-dev-g-t branch February 23, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants