Publish to Flathub#5569
Merged
GeorgesStavracas merged 6 commits intoobsproject:masterfrom Nov 24, 2021
Merged
Conversation
This causes no problem whatsoever, it's just good to keep some hygiene over ignored files. Add generated Flatpak files and folders to .gitignore.
Add a start-of-file heading, and reindent some line. Only cosmetics, no behavioral changes here.
Rename "flatpak_builder" to "generate_bundle", and set the display name to "Generate Flatpak Bundle". This will make it less vague, which will come in handy since next commits will add new jobs to this workflow.
Member
Author
|
For publishing to work, two new secrets must be added to the repository:
|
dodgepong
reviewed
Nov 24, 2021
dodgepong
reviewed
Nov 24, 2021
None of the changes included in v4 affect OBS Studio, but since we're already touching this code, let's make sure it's updated.
Now that Flatpak has achieved full feature parity with non-Flatpak builds, it is time to publish it directly into Flathub. Add a new "publish" job to the Flatpak workflow that builds and publishes to Flathub Beta, and to Flathub (if the release tag doesn't contain '-rc').
It just cannot get more official than this!
48176ad to
f081575
Compare
barthalion
approved these changes
Nov 24, 2021
Contributor
barthalion
left a comment
There was a problem hiding this comment.
With my Flathub's admin/maintainer hat on, LGTM.
Member
Author
|
Thanks everyone for reviewing this PR. I'm particularly excited about this! Seems like Jim is okay with landing this, so I'll take the liberty to go ahead and merge. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Publish GitHub releases of OBS Studio directly into Flathub and Flathub Beta. All releases are published to Flathub Beta, and only stable releases are published to Flathub.
Motivation and Context
Currently the only Linux distribution officially supported by the OBS Studio community is Ubuntu, through the community PPA. We've been slowly growing support for Flatpaks, which covers support for a lot more distros beyond Ubuntu. Since #4994 the Flatpak builds achieved complete feature parity with regular builds.
This is the last big step in the Flatpak front: publish GitHub releases directly into Flathub.
Flathub already has a separate repository for OBS Studio, and I've been manually publishing releases there, but it doesn't have services integration.
How Has This Been Tested?
The nature of this change makes it hard to manually test it, but I've forged fake releases in my fork to exercise this new job:
Here's what you have to verify in these runs:
Types of changes
Checklist: