libobs-winrt,win-capture: Cursor toggle exceptions#4668
Merged
Conversation
A user has reported that toggling the cursor can cause exceptions. Propagate that information upward, so we can reset the capture. Display capture never needed to call the function in the first place. Shuffle around window capture code to make a common reset function. Builds on PR obsproject#4663.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A user has reported that toggling the cursor can cause exceptions.
Propagate that information upward, so we can reset the capture.
Display capture never needed to call the function in the first place.
Shuffle around window capture code to make a common reset function.
Builds on PR #4663.
Motivation and Context
Don't want to crash.
How Has This Been Tested?
WGC display capture cursor toggle still works.
WGC window capture cursor toggle still works. Capture reset and recovery tested by modifying function return value in debugger.
Types of changes
Checklist: