Skip to content

UI: Fix invalid check for Remove Multiple Sources dialog result#4550

Merged
derrod merged 1 commit into
obsproject:masterfrom
WizardCM:fix-remove-multiple-sources
Apr 18, 2021
Merged

UI: Fix invalid check for Remove Multiple Sources dialog result#4550
derrod merged 1 commit into
obsproject:masterfrom
WizardCM:fix-remove-multiple-sources

Conversation

@WizardCM

Copy link
Copy Markdown
Member

Description

When Undo/Redo was added, this comparison was accidentally removed. The resulting conditional would always return true, causing sources to be deleted unintentionally.

Motivation and Context

Fixes #4546

How Has This Been Tested?

Click "No" when deleting multiple sources

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@WizardCM WizardCM added the kind/bug Categorizes issue or PR as related to a bug. label Apr 18, 2021
@WizardCM WizardCM added this to the OBS Studio 27.0 milestone Apr 18, 2021
@derrod derrod merged commit 2aed4be into obsproject:master Apr 18, 2021
@WizardCM WizardCM deleted the fix-remove-multiple-sources branch June 10, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking 'no' on remove confirmation acts the same as 'yes'

3 participants