mac-virtualcam: Hide logging behind debug flag#4508
Merged
jp9000 merged 1 commit intoApr 13, 2021
Conversation
Hides the DLog and DLogFunc macros behind the -DDEBUG flag, causing the logs to only appear in testing environments. On production build, calls to these macros will result in nothing happening.
9514d41 to
94032e8
Compare
Member
|
I've fixed it for you, but in the future, make sure to wrap your commit description text at 72 columns. Google "50/72 commits" for more info. |
Member
Author
|
Oh sorry, I'll be sure to look at it again |
Member
@gxalpha
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hides the DLog and DLogFunc macros behind the -DDEBUG flag, causing the logs to only appear in testing environments.
On production build, calls to these macros will result in nothing happening.
Motivation and Context
Console logs in this amount:

are hilarious.
On production, there will be no more unnecessary debug logs, leaving the console like this:

How Has This Been Tested?
macOS 11.2.3, Intel
Building in Xcode keeps the logs, outside of it with the
-DCMAKE_BUILD_TYPE=RelWithDebInfoflag, the logs are gone.Types of changes
Checklist: