Reenable browser source in Flatpak#4431
Conversation
It seems that the browser source works inside a Flatpak sandbox and/or Wayland with CEF 4280, so let's try and reenable it. This reverts commit e64c617.
5998276 to
c8d1c0a
Compare
|
The red macOS CI is our old device detach failure friend again |
|
Hey, I just tested it (flatpak from the CI, Fedora 33, GNOME under Wayland session). Thank you so much for your work on the Wayland support. Adding a browser source works, the content displays and the audio can be heard. However, when adding a browser dock, the content of the window remains transparent (and maybe not related but I'm unable to dock that window into the main window):
I looked at the logs while opening the window but didn't see anything. I also tried building OBS with the browser source in a VM, the result was the same, so I believe it must come from Wayland and not flatpak. |
|
Thanks, this is exactly the kind of testing I was hoping to get with the Flatpak CI 🙂 I'd consider using the browser source on Wayland unstable for now. Personally, I doubt CEF gets any testing on Wayland. But since OBS Studio now supports running on Wayland, I think it's better if you could please open an issue here in GitHub (and please CC me there so I don't forget) |
|
I believe this PR is good to land. As demonstrated by @rmnvgr, the Flatpak really does contain the browser source now, which is the goal of this PR. The bugs are not caused or related to this PR, but it indeed enabled bugs like this to be caught through Flatpak 🙂 |
|
Putting this in draft for now to prevent merging until #4436 is ready to merge. |
|
Since obsproject/obs-browser#284 was merged instead of #4436, is this ready to go now? |
|
Ah, thanks, yes it's probably good to go now 🙂 Undrafting |
Description
It seems that the browser source works inside a Flatpak sandbox and/or Wayland with CEF 4280, so let's try and reenable it.
This reverts commit e64c617.
Motivation and Context
The browser source is pretty important! 🙂
In addition to that, this is another step towards feature parity of the Flatpak build and regular builds.
How Has This Been Tested?
Types of changes
I'm actually not sure? It could either be
or
Checklist: