obs-outputs: Use system-wide FTL-SDK if present#4018
obs-outputs: Use system-wide FTL-SDK if present#4018jp9000 merged 1 commit intoobsproject:masterfrom
Conversation
|
We will be deprecating FTL entirely now that Mixer is dead. Expect a post about it on our Github discussions page soon. |
That's unfortunate. Especially because there are a few services and projects using that as a primary protocol |
Then they should investigate using a protocol that is open and standard. |
We will be working on standardizing and reviving the FTL protocol hopefully you guys will be willing to wait until we can do this before deprecating? Edit: If you are interested in talking with use about it you can join this server https://discord.gg/FhE7ApBJst |
|
Please direct further FTL discussion here: #4021 |
RytoEX
left a comment
There was a problem hiding this comment.
A single question about if + if versus if + elseif.
581dcd9 to
45f635c
Compare
|
Rebased and fixed @RytoEX remark. Can this be merged, as the FTL codebase will still be in OBS at least until next year? |
RytoEX
left a comment
There was a problem hiding this comment.
Please use the correct commit prefix, obs-outputs: .
Can this be merged, as the FTL codebase will still be in OBS at least until next year?
As with any PR, this may be merged if and when time allows and if we're comfortable merging it.
Yeah no pressure. I was just unsure if this PR will be ignored because of the deprecation |
45f635c to
20568a0
Compare
|
The Windows build failing should be attributed to obs-browser (commits 0a614cb and onwards) |
|
On Fri, Jan 8, 2021 at 12:15 PM Sefa Eyeoglu ***@***.***> wrote:
The Windows build failing should be attributed to obs-browser (commits
0a614cb and onwards)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Yes thank you 🙏
|
Yeah, we're aware of the Windows CI failures, and we're working on it. |
|
To fix the Windows builds, please rebase on latest master and force push. Thanks! |
To support FTL, it needed to be present in-tree to be compiled. This PR adds support for system-wide installations of libftl. It uses pkg-config to find the system-wide installation. If pkg-config can't provide libftl we just fall back to using the in-tree submodule. If that's also not available it won't be included at all like before.
20568a0 to
a920e39
Compare
|
There we go! Rebased. |
Related #3834
Fixes #3881
Description
To support FTL, it needed to be present in-tree to be compiled. This PR adds support for system-wide installations of libftl.
It uses pkg-config to find the system-wide installation.
If pkg-config can't provide
libftlwe just fall back to using the in-tree submodule.If that's also not available it won't be included at all like before.
Motivation and Context
The OBS Studio package on Arch Linux does not come with FTL support, as both FTL-SDK and OBS Studio lacked the capabilities to use system libraries. (See [1] [2])
The former was solved by a fork as development stopped (The company behind it, Mixer, is not operating anymore). This PR should fix the latter problem upstream, instead of having to maintain patchsets in Arch Linux.
How Has This Been Tested?
I tested this on my Arch Linux machine. I installed ftl-sdk from the AUR and then built OBS in portable-mode. After starting the binary I tested the output by streaming to my instance of the Lightspeed streaming server.
Types of changes
Checklist:
Not really sure about the first and last checkboxes, as I didn't change anything in code. I guess they are not applicable.