Skip to content

UI: Add Chromium-compatible NSApplication subclass#2386

Merged
jp9000 merged 1 commit into
obsproject:masterfrom
tbodt:mac-panels
Feb 10, 2020
Merged

UI: Add Chromium-compatible NSApplication subclass#2386
jp9000 merged 1 commit into
obsproject:masterfrom
tbodt:mac-panels

Conversation

@tbodt

@tbodt tbodt commented Feb 9, 2020

Copy link
Copy Markdown
Contributor

This fixes some crashes in browser panels on Mac, but it's also harmless
if browser panels aren't enabled.

Description

Some parts of Chromium apparently can't live without knowing whether they're being called from the Mac event loop. To satisfy them, this PR implements the isHandlingSendEvent method on NSApp.

Motivation and Context

This fixes a crash led to a crash when you right click a browser panel.

How Has This Been Tested?

Tested in combination with obsproject/obs-browser#197, makes it crash less.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.

This fixes some crashes in browser panels on Mac, but it's also harmless
if browser panels aren't enabled.
@WizardCM WizardCM added kind/bug Categorizes issue or PR as related to a bug. kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. labels Feb 9, 2020
@jp9000 jp9000 merged commit 6a561f7 into obsproject:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants