Skip to content

frontend, libobs: Fix source toolbar crash#13539

Open
Penwy wants to merge 3 commits into
obsproject:masterfrom
Penwy:fix-toolbar-crash
Open

frontend, libobs: Fix source toolbar crash#13539
Penwy wants to merge 3 commits into
obsproject:masterfrom
Penwy:fix-toolbar-crash

Conversation

@Penwy

@Penwy Penwy commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

This fixes two separate issues that caused obs to potentially crash when creating a toolbar for a source type from a non-loaded module.

  • This checks whether a source type does come from a loaded module before creating a special source toolbar for it
  • It checks for module existence before trying to fetch a localised string from it in obs_module_get_locale_string

Motivation and Context

Fixes #11457 , and other potential crashes.

How Has This Been Tested?

Ubuntu 24.04 Portable, verified no crash, and toolbar was correctly created/not created.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Penwy Penwy changed the title frontend, libobs: Fix source toolbar crash. frontend, libobs: Fix source toolbar crash Jun 10, 2026
@Warchamp7 Warchamp7 added kind/bug Categorizes issue or PR as related to a bug. area/ui-ux Anything to do with changes or additions to UI/UX elements. kind/crash labels Jun 10, 2026
Comment thread libobs/obs-module.c
@Penwy Penwy force-pushed the fix-toolbar-crash branch from 244b3b5 to e1f2982 Compare June 10, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui-ux Anything to do with changes or additions to UI/UX elements. kind/bug Categorizes issue or PR as related to a bug. kind/crash

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when selecting wasapi_process_output_capture source under non-windows

3 participants