Skip to content

libobs: Add devices_match to null monitor#12814

Merged
RytoEX merged 1 commit intoobsproject:masterfrom
pkviet:nullaudio
Nov 26, 2025
Merged

libobs: Add devices_match to null monitor#12814
RytoEX merged 1 commit intoobsproject:masterfrom
pkviet:nullaudio

Conversation

@pkviet
Copy link
Copy Markdown
Member

@pkviet pkviet commented Nov 12, 2025

Description

Fixes #12810 where compilation fails for null monitor due to
devices_match symbol not found.
This adds the devices_match function to null monitor to fix linking issues on linux when pulse audio is disabled.

Motivation and Context

Fixes a bug.

How Has This Been Tested?

Untested. I'll leave it to the OP of the issue to check the fix works.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

This adds the devices_match function to null monitor to fix linking
issues on linux when pulse audio is disabled.
Fixes obsproject#12810

Signed-off-by: pkv <pkv@obsproject.com>
@pkviet pkviet added the Bug Fix Non-breaking change which fixes an issue label Nov 12, 2025
@pkviet pkviet added this to the OBS Studio 32.0 milestone Nov 12, 2025
@pkviet
Copy link
Copy Markdown
Member Author

pkviet commented Nov 13, 2025

@melynx
could you check and confirm ? (not that i have any doubt about the fix; it's just our standard procedure in the project)

@Chiitoo
Copy link
Copy Markdown
Contributor

Chiitoo commented Nov 14, 2025

For what it is worth, works for me on Gentoo Linux, without PulseAudio.

Thank you!

@melynx
Copy link
Copy Markdown

melynx commented Nov 24, 2025

Hey. So sorry about the late reply. It is working for me too.

@RytoEX RytoEX self-assigned this Nov 24, 2025
Copy link
Copy Markdown
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@RytoEX RytoEX merged commit 4ea2074 into obsproject:master Nov 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Non-breaking change which fixes an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure on Linux when PulseAudio is disabled - missing devices_match symbol

4 participants