Skip to content

build-aux: Update Flatpak CEF from 103/5060 to 127/6533#11218

Merged
RytoEX merged 1 commit into
obsproject:masterfrom
tytan652:update-fp-cef-to-127
Aug 31, 2024
Merged

build-aux: Update Flatpak CEF from 103/5060 to 127/6533#11218
RytoEX merged 1 commit into
obsproject:masterfrom
tytan652:update-fp-cef-to-127

Conversation

@tytan652

@tytan652 tytan652 commented Aug 29, 2024

Copy link
Copy Markdown
Collaborator

Description

Flatpak counterpart of #11213

Reminder that obsproject/obs-browser#450 (or an alternative) is required to avoid the shutdown crash with browser docks.

The CEF module is also modified to:

  • Use the pre-built wrapper included in the tarball
  • Preserve debug symbols inside its binaries
    • The copy done later by OBS Studio build-system will be split from its debug symbols

Motivation and Context

Update CEF on the Flatpak and preserve CEF debug symbols which will be put in the .Debug Flatpak extension.

How Has This Been Tested?

Build with CEF and debug symbols are generated and compressed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652
build-aux: Update Flatpak CEF from 103/5060 to 127/6533
ceae99c 
The CEF module is also modified to:
- Use the pre-built wrapper included in the tarball
- Preserve debug symbols inside its binaries
  - The copy done later by OBS Studio build-system will be split from
    its debug symbols
@tytan652 tytan652 added Seeking Testers Build artifacts on CI kind/bug Categorizes issue or PR as related to a bug. kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. platform/linux Categorizes issue or PR as affecting Linux specifically labels Aug 29, 2024
@tiberium-v

tiberium-v commented Aug 29, 2024

Copy link
Copy Markdown

Tested on x11 (i3 wm), via flatpak artifact without problems. Also, Custom Browser Docks Window are behaving normal

@colingourlay

colingourlay commented Aug 29, 2024 •
edited
Loading

Copy link
Copy Markdown

Looking great on macOS (Sonoma) 14.6.1. Virtual camera has stopped working, but browser sources are all perfect. Tested recent Chromium features by using CSS mask-image to mask areas of the page with an local SVG <mask>. Flawless! Thank you so much for this update.

@RytoEX RytoEX self-assigned this Aug 30, 2024
@RytoEX

RytoEX commented Aug 30, 2024

Copy link
Copy Markdown
Member

Looking great on macOS (Sonoma) 14.6.1. Virtual camera has stopped working, but browser sources are all perfect. Tested recent Chromium features by using CSS mask-image to mask areas of the page with an local SVG <mask>. Flawless! Thank you so much for this update.

As a note, this PR only updates the Flatpak version. PR #11213 updates Windows and macOS.

@RytoEX RytoEX added this to the OBS Studio 31 milestone Aug 30, 2024
@RytoEX

RytoEX commented Aug 30, 2024

Copy link
Copy Markdown
Member

This should now be unblocked by 16011f7.

RytoEX
RytoEX approved these changes Aug 30, 2024
View reviewed changes

@RytoEX RytoEX left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RytoEX RytoEX merged commit b7dbaf4 into obsproject:master Aug 31, 2024
@tytan652 tytan652 deleted the update-fp-cef-to-127 branch August 31, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RytoEX RytoEX RytoEX approved these changes

@GeorgesStavracas GeorgesStavracas GeorgesStavracas approved these changes

Assignees

@RytoEX RytoEX

Labels

kind/bug Categorizes issue or PR as related to a bug. kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. platform/linux Categorizes issue or PR as affecting Linux specifically Seeking Testers Build artifacts on CI

Projects

None yet

Milestone

OBS Studio 31.0

Development

Successfully merging this pull request may close these issues.

5 participants

@tytan652 @tiberium-v @colingourlay @RytoEX @GeorgesStavracas